Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @TzahiTaub)

crates/blockifier/src/test_utils/cairo_compile.rs line 79 at r1 (raw file):

}

/// Verifies that the required dependencies are available before compiling.

Suggestion:

/// Verifies that the required dependencies are available before compiling; panics if unavailable.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @nimrod-starkware, and @TzahiTaub)

crates/blockifier/src/test_utils/cairo_compile.rs line 79 at r1 (raw file):

}

/// Verifies that the required dependencies are available before compiling.

Done.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @TzahiTaub)

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

a discussion (no related file):
What happens ATM if we have the package in the wrong version? We fail the comparison, and if we fix we fix the wrong local version we use (and hopefully fails the CI)

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

        cairo_lang_version.trim(),
        expected_cairo_lang_version.trim(),
        "cairo-lang not found. Please run:\npip3.9 install -r {}/{}\nthen rerun the test.",

We might have the package in the wrong version

Suggestion:

cairo-lang version {} not found...., expected_cairo_lang_version.trim().rsplit("=").next().unwrap()

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @TzahiTaub)

a discussion (no related file):

The CI installs whatever is in the requirements.txt file, if that version is "wrong" there's nothing we can check

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

better?

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

a discussion (no related file):

I meant if our installed local version doesn't match the requirements file.

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

Yes, though when the package isn't installed, we'll get (installed version: ) then maybe if cairo_lang_version.is_empty() {"not installed"} else { cairo_lang_version}, and raise the trim()` above as you did for the expected one.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

* and raise the not a part of the code :)

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

a discussion (no related file):

the fix command also compares versions (same cairo0_compile is called), so you will also fail to fix

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

done. however, can't raise the trim ("value dropped"). defined an intermediate var to call trim once

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)